From: Colin Walters <walters@verbum.org>
Date: Thu, 11 Aug 2011 10:06:38 +0000 (-0400)
Subject: appDisplay: Don't expose "Add as favorite" for window-backed apps
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~7954
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=7f1d2825fdda2b1ff040e8881371c62d5e1cbaaf;p=gnome-shell.git

appDisplay: Don't expose "Add as favorite" for window-backed apps

We don't know how to do it.  Similarly, don't allow New Window.

https://bugzilla.gnome.org/show_bug.cgi?id=648149
---

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index a69b677b6..291e3d63b 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -673,17 +673,18 @@ AppIconMenu.prototype = {
             item._window = windows[i];
         }
 
-        if (windows.length > 0)
-            this._appendSeparator();
-
-        let isFavorite = AppFavorites.getAppFavorites().isFavorite(this._source.app.get_id());
+        if (!this._source.app.is_window_backed()) {
+            if (windows.length > 0)
+                this._appendSeparator();
 
-        this._newWindowMenuItem = this._appendMenuItem(_("New Window"));
-        this._appendSeparator();
+            let isFavorite = AppFavorites.getAppFavorites().isFavorite(this._source.app.get_id());
 
-        this._toggleFavoriteMenuItem = this._appendMenuItem(isFavorite ? _("Remove from Favorites")
-                                                                    : _("Add to Favorites"));
+            this._newWindowMenuItem = this._appendMenuItem(_("New Window"));
+            this._appendSeparator();
 
+            this._toggleFavoriteMenuItem = this._appendMenuItem(isFavorite ? _("Remove from Favorites")
+                                                                : _("Add to Favorites"));
+        }
     },
 
     _appendSeparator: function () {